fix: repair cross-package bugs so all tests and types pass - #87
Open
stooit wants to merge 1 commit into
Open
Conversation
- utils: rename debounce hook reconciled; re-export useDebounce as useSearchDebounce from @e2e/utils so apps/web import resolves - ui/Button: forward aria-label to the button element for icon-only buttons so the accessible-label test passes - ui/DataTable: fix stale-closure in handleSort via functional state updater so the controlled re-render test passes - utils/date: use en-AU dateStyle:short locale to match expected format - tsconfig: add bun-types to compilerOptions.types so bun:test resolves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and eliminates all type errors across the monorepo.
bun run test→ 13 pass / 0 fail;tsc --noEmit→ 0 errors. No test files modified, no dependencies added.Bugs fixed
apps/web/src/lib/api.tsimported a debounce hook name that no longer existed (tsc: no exported member; api test: expecteduseSearchDebounce). Reconciled the export in@e2e/utilssouseSearchDebounceis exported and the app import resolves.aria-labelto the underlying<button>, satisfying the accessible-label test.formatDatenow usesen-AUdateStyle: "short", matching the expected1/03/2024-style output instead of the previous01/03/2024.bun:testtypes. Addedbun-types(existing dep) tocompilerOptions.typesso thebun:testimport in test files resolves undertsc --noEmit. No test files were touched.Verification
bun run test— 13 pass, 0 failnpx tsc --noEmit— exit 0, no outputAssumptions
en-AUlocale chosen because it produces the exact expected day/month ordering with a non-zero-padded day.